Can not change encryption directory

[nickvergessen]

Fix #6769

@schiessle there is an issue here

1. You require a path relative to the root storage
2. You use the view
3. The view does not allow /../ in paths

Therefor you can only change the root inside your data directory, but not move it out of it.
If that is intended, we should have this commit here and display a better error message

[nickvergessen]

Currently the View returns null, because

server/lib/private/Files/View.php

Line 1103 in b9b88aa

if (Filesystem::isValidPath($path)

returns false and therefor nothing is executed.

[MorrisJobke]

@schiessle Any news for this? Would be good to get it in.

[MorrisJobke]

Let's move this to 14.

[codecov]

Codecov Report

Merging #6805 into master will decrease coverage by 16.83%.
The diff coverage is 0%.

@@              Coverage Diff              @@
##             master    #6805       +/-   ##
=============================================
- Coverage     51.93%   35.09%   -16.84%     
  Complexity    25418    25418               
=============================================
  Files          1609     1609               
  Lines         95329    95329               
  Branches       1378     1378               
=============================================
- Hits          49506    33454    -16052     
- Misses        45823    61875    +16052

Impacted Files	Coverage Δ	Complexity Δ
core/Command/Encryption/ChangeKeyStorageRoot.php	0% <0%> (-88.55%)	31 <0> (ø)
...s/dav/lib/CalDAV/BirthdayCalendar/EnablePlugin.php	0% <0%> (-100%)	7% <0%> (ø)
lib/private/App/AppStore/Version/Version.php	0% <0%> (-100%)	3% <0%> (ø)
...pps/files/lib/Activity/Settings/FavoriteAction.php	0% <0%> (-100%)	8% <0%> (ø)
apps/files/lib/Activity/Settings/FileChanged.php	0% <0%> (-100%)	8% <0%> (ø)
apps/federation/lib/Hooks.php	0% <0%> (-100%)	4% <0%> (ø)
apps/dav/lib/CalDAV/Activity/Setting/Calendar.php	0% <0%> (-100%)	8% <0%> (ø)
...pFramework/Db/MultipleObjectsReturnedException.php	0% <0%> (-100%)	1% <0%> (ø)
apps/files/lib/Activity/Settings/FileCreated.php	0% <0%> (-100%)	8% <0%> (ø)
core/Command/TwoFactorAuth/Enable.php	0% <0%> (-100%)	4% <0%> (ø)
... and 528 more

[schiessle]

tested and works with my changes

[schiessle]

second reviewer needed

[nickvergessen]

👍 for not my code