Inputs border to main bg and fix white inputs#6692
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6692 +/- ##
=========================================
Coverage ? 30.71%
Complexity ? 1466
=========================================
Files ? 94
Lines ? 5148
Branches ? 0
=========================================
Hits ? 1581
Misses ? 3567
Partials ? 0 |
Member
Author
|
Bump? 😭 |
Member
|
@skjnldsv Maybe you can add some variables for the border color values? Otherwise it will get messy to maintain those different transparency levels used. The rest looks good 👍 |
Member
Author
|
Hum, it's not supposed to be edited. But it doesn't hurt I guess! :) |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
bbd1997 to
27a6bbc
Compare
Member
Author
|
@juliushaertl Done ;) |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
91df287 to
c2abc58
Compare
juliusknorr
approved these changes
Oct 4, 2017
Member
Author
|
@nextcloud/designers the drone fails but not because of this :) |
rullzer
approved these changes
Oct 10, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the variable pr, the white radio/checkboxes have been broken.
They need to be base on the white colour only, and not relative to the text colour or bg colour.
Therefore, this is fixed.
On the other hand, the border & bg of the inputs needs to be based on the main background colour, not the text. This will ensure a better contrast! :)
@nextcloud/designers