Conversation
Codecov Report
@@ Coverage Diff @@
## master #6669 +/- ##
============================================
- Coverage 53.03% 53.03% -0.01%
Complexity 22583 22583
============================================
Files 1417 1417
Lines 87866 87873 +7
Branches 1341 1341
============================================
+ Hits 46600 46601 +1
- Misses 41266 41272 +6
|
278241a to
434ed4e
Compare
The default background of the quota bar should be white instead of grey (like in the files sidebar). |
|
@MorrisJobke This has been requested by @jancborchardt :)
It's grey in the sidebar! :) |
|
Quota update pushed! |
|
Okay, let's review @nextcloud/designers |
|
Wow, looks great, all of it! 👍 |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2727c41 to
08c718d
Compare
|
Integration tests fail: And the upload progress bar is now grey instead of blue. |
|
|
Thank you so much @danxuliu ! :)
|
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
|
89085c7 to
9296d6c
Compare
|
Simple idea too, what do you think @jancborchardt @MorrisJobke ? We could also implement this in the file list when dropping in a folder. Displaying a progressbar on the bottom of the row? :) |
Mmmmh ... I don't like the shadow around the time and the black theme is confusing. I need to see it also in real life to properly judge if it feels right. 😉 |
|
I'm also fine with getting this in now and fix the progress bar design afterwards, if it gets an overhaul anyways. (to not make this even bigger and bigger) |
Do not judge the colours, the shadow isn't right because I didn't edit it ^^' @MorrisJobke Completely agree, I won't add the progressbar into this one anyway, was just an idea like this :) |
92ce6a1 to
8fc7d87
Compare
|
@MorrisJobke @jancborchardt @danxuliu please review! :) |
|
@skjnldsv The loong bar on the top is a bit much. Let’s just keep it a short progress bar where you can quickly see the percentage. :) Of course the current bar should be redesigned to use the new thin bar we use for quota too. Otherwise good! :) |
|
@jancborchardt is it a review? 😆 |
|
Yes, my review from earlier still stands :) |
removed border-radius on big quota from the main settings page Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
8fc7d87 to
b9a8ba7
Compare
|
This is great!I really like that someone is paying attention to details.Best regardsDaniel HanssonTech and MeSent from mobile, sorry for typos.Den 28 sep. 2017 17:48 skrev John Molakvoæ <notifications@github.com>:Merged #6669.
—You are receiving this because you are on a team that was mentioned.Reply to this email directly, view it on GitHub, or mute the thread.
|



Uh oh!
There was an error while loading. Please reload this page.