Downstream - removal of outdated API#6146
Merged
MorrisJobke merged 1 commit intomasterfrom Aug 16, 2017
Merged
Conversation
nickvergessen
approved these changes
Aug 16, 2017
Member
nickvergessen
left a comment
There was a problem hiding this comment.
Fine by me, as far as I know apps can provide ext. storages?
LukasReschke
approved these changes
Aug 16, 2017
Member
Author
Correct: https://github.com/icewind1991/files_external_ftp |
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
29d41ce to
6536105
Compare
Codecov Report
@@ Coverage Diff @@
## master #6146 +/- ##
============================================
+ Coverage 52.99% 53.15% +0.16%
+ Complexity 22697 22609 -88
============================================
Files 1407 1404 -3
Lines 87857 87594 -263
Branches 1327 1327
============================================
+ Hits 46557 46560 +3
+ Misses 41300 41034 -266
|
Member
Author
|
Failure was due to missing sign-off - added and will merge it now. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downstream of owncloud/core#28073
I will additionally also downstream owncloud/core#26539 to avoid update problems with the usage of this.