fix(theming): Fix favicon and touchicon ratios#57653
Merged
Conversation
On some systems (depending on imagick version I think) the ratio would be messed up on the touchicon, favicon and link preview images. This fixes it without breaking other systems. Signed-off-by: Côme Chilliet <[email protected]>
come-nc
requested review from
Altahrim,
ArtificialOwl,
leftybournes and
salmart-dev
and removed request for
a team
Contributor
Author
|
A warm thank you to @nilsding who found the fix. Not sure why that works, but it does. |
nilsding
approved these changes
Jan 20, 2026
Contributor
Author
|
/backport to stable32 |
Contributor
Author
|
/backport to stable31 |
miaulalala
approved these changes
Jan 20, 2026
Member
I'd love to know, this looks so strange and doesn't make any sense to me 🙈 |
5 tasks
cristianscheid
approved these changes
Jan 20, 2026
This was referenced Jan 20, 2026
Merged
Contributor
|
Fix was reverted by #57653 for 34. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On some systems (depending on imagick version I think) the ratio would
be messed up on the touchicon, favicon and link preview images.
This fixes it without breaking other systems.
Checklist
3. to review, feature component)stable32)