Conversation
Otherwise there are issues with string values looking like numbers. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
To avoid surprises with corner cases. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Contributor
Author
|
/backport to stable32 |
Contributor
Author
|
/backport to stable31 |
CarlSchwan
approved these changes
Jan 13, 2026
Altahrim
approved these changes
Jan 13, 2026
provokateurin
approved these changes
Jan 13, 2026
This was referenced Jan 13, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Without
strict:true, array_search has an unexpected behavior with string looking like numbers.Example:
I splitted in several commits to ease backporting a bit.
The issue was spotted with user_ldap user cache, but all instances of array_search could be impacted with such a corner case so I added
strict:trueto all array_search calls, apart from object arrays.Checklist
3. to review, feature component)stable32)