fix: allow renaming files with just update permissions#57374
fix: allow renaming files with just update permissions#57374icewind1991 wants to merge 3 commits intomasterfrom
Conversation
|
/compile |
icewind1991
added
3. to review
icewind1991
requested review from
Altahrim,
ArtificialOwl,
leftybournes,
provokateurin,
susnux and
szaimen
and removed request for
a team
|
(I'll rebase etc once reviewed) |
mgallien
left a comment
mgallien
left a comment
There was a problem hiding this comment.
tested with the desktop client and works fine
icewind1991
force-pushed
the
rename-dav-permissions
branch
from
0f7b6d9 to
de3587d
Compare
|
@icewind1991 will this change be backported to stable branches ? |
icewind1991
force-pushed
the
rename-dav-permissions
branch
from
de3587d to
8a6bf8a
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
rename-dav-permissions
branch
from
8a6bf8a to
cd2a74f
Compare
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
| return true; | ||
| } | ||
|
|
||
| // we allow renaming the file if either the file has update permissions |
There was a problem hiding this comment.
But does this not just mean write permissions to the file?
Do we not need to check the containing folder for update permission?
There was a problem hiding this comment.
I think that would be the delete+create case I think
There was a problem hiding this comment.
So if I share a folder with a file and only allow read+write then recipient still can rename the file inside the folder?
Would this not be unexpected as renaming is destructive if you expect the file to have a specific name?
If that is expected behavior then all good!
6 participants
Only moving to another folder needs the delete+create permissions, for moving in the same folder just update is enough.
TODO: