fix: allow moving from of non-resharable to other share if the user has delete permissions#57284
Merged
icewind1991 merged 2 commits intomasterfrom Jan 6, 2026
Merged
Conversation
icewind1991
requested review from
leftybournes,
salmart-dev and
yemkareems
and removed request for
a team
…as delete permissions Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
allow-cross-share-move-delete
branch
from
6ea6558 to
8cfb490
Compare
CarlSchwan
approved these changes
Dec 30, 2025
susnux
approved these changes
Jan 6, 2026
Member
Author
|
/backport to stable32 |
Member
Author
|
/backport to stable31 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds another carve-out for the check added in #54801
Moving from a share with "read+delete" permissions to another share is blocked since #54801 since the recipient doesn't have share permissions.
However, it's possible for the recipient to move the file out of the share (since they have delete permissions) and then move it into a share afterwards.
Since the 2-step process is allowed, it makes sense to allow the user doing both steps in one step.