fix(Teams): Use string team IDs on teams iteration#57146
Open
fix(Teams): Use string team IDs on teams iteration#57146
Conversation
Signed-off-by: Git'Fellow <[email protected]>
Signed-off-by: Git'Fellow <[email protected]>
Merged
This was referenced Jan 29, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TeamManager::getSharedWithList()receives an array of team ID strings fromTeamsApiController, but its fallback code path tries to callgetId()on those strings as if they wereTeamobjects.server/core/Controller/TeamsApiController.php
Line 69 in 89fcefb
This PR changes the fallback to treat
$teamsas an array of IDs and matches the actual input contract from the controller to avoid the type error.Type error stack
Checklist
3. to review, feature component)stable32)