[stable31] fix(core): RTL legacy snapper width#56449
Merged
AndyScherzinger merged 2 commits intostable31from Nov 30, 2025
Merged
[stable31] fix(core): RTL legacy snapper width#56449AndyScherzinger merged 2 commits intostable31from
AndyScherzinger merged 2 commits intostable31from
Conversation
paulijar
approved these changes
Nov 14, 2025
Contributor
|
/compile |
Contributor
|
@paulijar needed to be rebased before compile - now it conflicts |
After ec9e283 there was still such a problem with the legacy app navigation snapper that its width was only 266 px on the RTL layout instead of the normal 300 px. The 266 px is the default width of Snap.js module. While the left side snapper width is configured with the property maxPosition, the right side snapper is configured by passing a negative value for the property minPosition. Signed-off-by: Pauli Järvinen <pauli.jarvinen@gmail.com>
paulijar
force-pushed
the
backport/56425/stable31
branch
from
70ad5fe to
0f82848
Compare
Contributor
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Contributor
Right. Perfect example, why it's usually a bad idea to store compilation results under version control: it turns trivial merges into non-trivial ones. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #56425
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.