fix(files_sharing): Hide 'Open locally' action#55992
fix(files_sharing): Hide 'Open locally' action#55992skjnldsv merged 1 commit intonextcloud:masterfrom
Conversation
fauzanfebrian
requested review from
artonge and
szaimen
and removed request for
a team
|
Before After |
fauzanfebrian
force-pushed
the
fix/hide-open-locally-action
branch
from
504c606 to
35b709b
Compare
|
/backport to stable32 |
|
/backport to stable31 please |
skjnldsv
added
bug
3. to review
|
Manual push for tests: #56060 |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
This patch ensures that the "Open locally" context menu item is not displayed for files in a share where the "download and sync" permission has not been granted. This prevents user confusion, as the action would fail anyway. The fix adds a permission check before rendering the menu item, and adds a corresponding unit test to verify this behavior. Resolves: nextcloud#54970 Signed-off-by: Fauzan <fauzanfebriann@gmail.com>
skjnldsv
force-pushed
the
fix/hide-open-locally-action
branch
from
35b709b to
a7509ae
Compare
|
See #56060 for local branch |
4 participants
This patch ensures that the "Open locally" context menu item is not displayed for files in a share where the "download and sync" permission has not been granted.
This prevents user confusion, as the action would fail anyway. The fix adds a permission check before rendering the menu item, and adds a corresponding unit test to verify this behavior.
Resolves: #54970
Summary
TODO
Checklist
3. to review, feature component)stable32)