feat(settings): Introduce TaskProcessingSuccessRate setup check#55716
feat(settings): Introduce TaskProcessingSuccessRate setup check#55716marcelklehr merged 7 commits intomasterfrom
Conversation
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
marcelklehr
requested review from
nfebe,
provokateurin and
salmart-dev
and removed request for
a team
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
marcelklehr
changed the title
|
Shouldn't there be logs somewhere, which they already monitor anyway? |
Normal processing errors are logged as warning, only unexpected errors are logged as errors. We could also raise the log level of normal errors to error. I'm uncertain if that's a good idea, as normal errors can sometimes be caused by users and thus wouldn't be a real setup issue. |
|
Every error is "unexpected" and not "normal", so I don't get the distinction here 🤔 |
|
What I called normal error is an error that is raised by the provider rather than the TaskProcessing module itself. I call it a normal error because the TaskProcessing module expects this kind of error. These can be validation errors that are due to user mistakes or errors that hint at more grave issues. |
julien-nc
left a comment
julien-nc
left a comment
There was a problem hiding this comment.
Lgtm. A bit of nitpicking though.
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Co-authored-by: Julien Veyssier <julien-nc@posteo.net> Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Co-authored-by: Julien Veyssier <julien-nc@posteo.net> Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
|
/backport to stable32 |
4 participants
Summary
Currently, it can happen that AI tasks fail without the admin realizing that they misconfigured their instance. This setup check makes the admin aware about potential issues with the AI apps.
Checklist
3. to review, feature component)stable32)