Merged
Conversation
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
requested review from
ArtificialOwl and
nfebe
and removed request for
a team
nickvergessen
approved these changes
Oct 10, 2025
joshtrichards
approved these changes
Oct 11, 2025
Member
joshtrichards
left a comment
joshtrichards
left a comment
There was a problem hiding this comment.
Makes sense I think.
Also probably needs a config sample + Preview chapter doc adjustment since MP3 is described as (vaguely) as "by default":
Contributor
Author
|
/backport to stable32 |
Contributor
Author
|
/backport to stable31 |
6 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
While embedding cover images into MP3 files is certainly a nice feature, and it’s useful that we can use them as previews, it still feels somewhat niche. However, since parsing MP3 files is complex and we’re aware of a few rough edges, I’d suggest disabling the provider by default.
Checklist
3. to review, feature component)stable32)