fix(ooo): don't catch general DB exceptions#55581
Merged
miaulalala merged 1 commit intomasterfrom Oct 7, 2025
Merged
Conversation
miaulalala
requested review from
nfebe,
salmart-dev and
yemkareems
and removed request for
a team
miaulalala
force-pushed
the
fix/noid/dont-catch-general-db-errors
branch
from
20febc4 to
0f70579
Compare
Signed-off-by: Anna Larch <anna@nextcloud.com>
miaulalala
force-pushed
the
fix/noid/dont-catch-general-db-errors
branch
from
0f70579 to
d4c9e09
Compare
CarlSchwan
approved these changes
Oct 6, 2025
Member
|
@miaulalala Backports? |
Contributor
Author
|
/backport to stable32 |
Contributor
Author
|
/backport to stable31 |
This was referenced Oct 7, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When creating an absence, the job doesn't differentiate between generalised DB errors and DoesNotExistException, thus simply returning even if the run was not successful. The job entry should remain in the oc_jobs table when a general DB error happens.
TODO
Checklist
3. to review, feature component)stable32)