Merged
Conversation
CarlSchwan
force-pushed
the
carl/missing-attributes
branch
from
2ad338e to
0fdd21f
Compare
CarlSchwan
requested review from
Altahrim,
come-nc and
nfebe
and removed request for
a team
Member
|
Please add them to https://github.com/nextcloud-libraries/rector in a similar way to https://github.com/nextcloud-libraries/rector/blob/main/config/nextcloud-27/nextcloud-27-deprecations.php. Then everyone can migrate automatically 😁 |
come-nc
reviewed
Oct 1, 2025
Member
Author
|
Rector rule nextcloud-libraries/rector#66 |
CarlSchwan
force-pushed
the
carl/missing-attributes
branch
from
0fdd21f to
a2639cb
Compare
Member
|
@CarlSchwan what about the other annotations/attributes pairs? |
CarlSchwan
force-pushed
the
carl/missing-attributes
branch
from
a2639cb to
473345f
Compare
CarlSchwan
added
the
pending documentation
Member
Author
Are there more missing? |
CarlSchwan
force-pushed
the
carl/missing-attributes
branch
from
473345f to
340edce
Compare
Member
Sorry, I was talking about the rector rules for these. |
come-nc
reviewed
Dec 15, 2025
lib/public/AppFramework/Http/Attribute/NoSameSiteCookieRequired.php
Outdated
Show resolved
Hide resolved
lib/private/AppFramework/Http/Attributes/TwoFactorSetUpDoneRequired.php
Outdated
Show resolved
Hide resolved
CarlSchwan
force-pushed
the
carl/missing-attributes
branch
from
340edce to
e90adb9
Compare
icewind1991
reviewed
Dec 30, 2025
7 tasks
Altahrim
approved these changes
Jan 12, 2026
provokateurin
previously requested changes
Jan 12, 2026
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
LGTM, but please deduplicate the hasAnnotationOrAttribute method. I think with this PR we have 4 copies or so...
CarlSchwan
force-pushed
the
carl/missing-attributes
branch
from
e90adb9 to
6eda80e
Compare
Member
Author
done |
come-nc
approved these changes
Jan 12, 2026
Member
|
But CI is very unhappy 🙈 |
CarlSchwan
force-pushed
the
carl/missing-attributes
branch
from
6eda80e to
9f42a17
Compare
Merged
CarlSchwan
force-pushed
the
carl/missing-attributes
branch
from
9f42a17 to
1edcda0
Compare
It's in our documentation but was never implemented. Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
Allow to replace the old annotation. Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
This didn't manage to get into NC 33 Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/missing-attributes
branch
from
c78d729 to
8bb13df
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add alternative attribute for the following annotations:
Checklist
3. to review, feature component)stable32)