[stable32] fix: Dispatch favorite event with an actual path#55127
Merged
AndyScherzinger merged 2 commits intostable32from Sep 15, 2025
Merged
[stable32] fix: Dispatch favorite event with an actual path#55127AndyScherzinger merged 2 commits intostable32from
AndyScherzinger merged 2 commits intostable32from
Conversation
The `$path` argument was added in #48612, but was never actually used by the callers. The path was therefore missing in the favorite/unfavorite events, which lead to a broken activity information. I also added a fallback to handle `addToFavorites` and `removeFromFavorites`, which are part of a public API, and are calling `tagAs` and `untag` without `$path`. Fix nextcloud/activity#2134 Signed-off-by: Louis Chemineau <louis@chmn.me>
backportbot
bot
requested review from
Altahrim,
AndyScherzinger,
CarlSchwan,
artonge,
come-nc and
provokateurin
and removed request for
a team
backportbot
bot
added
bug
3. to review
provokateurin
approved these changes
Sep 15, 2025
AndyScherzinger
approved these changes
Sep 15, 2025
artonge
approved these changes
Sep 15, 2025
It was not caught by the CI on master, but is blocking in the backports. Signed-off-by: Louis Chemineau <louis@chmn.me>
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #55122