[stable31] fix(files_sharing): use newPassword always for the unsaved password#55073
Merged
[stable31] fix(files_sharing): use newPassword always for the unsaved password#55073
newPassword always for the unsaved password#55073Conversation
susnux
requested review from
a team,
Antreesy,
nfebe,
salmart-dev,
sorbaugh and
szaimen
and removed request for
a team
Contributor
Author
|
/backport to stable32 |
Contributor
Author
|
/backport to master |
Antreesy
approved these changes
Sep 12, 2025
Contributor
Antreesy
left a comment
Antreesy
left a comment
There was a problem hiding this comment.
Tested, looks good code-wise
`newPassword` is the unsaved password, while `share.password` is the current saved password. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/files-sharing-password
branch
from
e95fadb to
ee97330
Compare
Contributor
Author
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
This was referenced Sep 12, 2025
This was referenced Sep 16, 2025
8 tasks
|
Is this patchable? Since it's vue and frontend? I am not sure |
Contributor
Author
|
@mpivchev not really, best to wait for the release on October 9, 2025 |
Member
|
Regression fix in #56278 |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
newPasswordis the unsaved password, whileshare.passwordis the current saved password.Checklist