fix(files_versions): ensure users IDs are strings#54728
Merged
AndyScherzinger merged 2 commits intomasterfrom Aug 29, 2025
Merged
fix(files_versions): ensure users IDs are strings#54728AndyScherzinger merged 2 commits intomasterfrom
AndyScherzinger merged 2 commits intomasterfrom
Conversation
skjnldsv
requested review from
nfebe,
susnux and
szaimen
and removed request for
a team
Member
Author
|
/backport to stable31 |
Member
Author
|
/backport to stable30 |
4 tasks
provokateurin
approved these changes
Aug 29, 2025
Member
|
Do we need to normalize to string here also or not needed? |
Member
Author
We could also sure :) |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
fix/version-autjo-string
branch
from
3944e18 to
1b7418f
Compare
Member
Author
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
AndyScherzinger
approved these changes
Aug 29, 2025
solracsf
reviewed
Aug 29, 2025
| // If version-label is defined make sure it is a string (prevent issue if the label is a number an PHP returns a number then) | ||
| label: version.props['version-label'] && String(version.props['version-label']), | ||
| author: version.props['version-author'] ?? null, | ||
| author: String(version.props['version-author']) ?? null, |
Member
There was a problem hiding this comment.
If version.props['version-author'] is missing, you’ll end up with "null" or "undefined" as the author ID because of operator precedence, no?
author: version.props['version-author'] != null ? String(version.props['version-author']) : null
Maybe I'm wrong perhaps :)
This was referenced Aug 29, 2025
4 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #54727
User IDs can be parsed as integers if the userid doesn't have an alphanumeric char in it.
It makes the
/displaynameapi throw.Checklist