fix(trashbin): Fix errors in the log on MOVE operations#54632
Merged
Conversation
dirname will return '.' for files at the root, which will cause an Exception that gets logged. Instead use \Sabre\Uri\split like other sabre plugins, to get an empty string for root directory. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
requested review from
Altahrim and
icewind1991
and removed request for
a team
susnux
approved these changes
Aug 25, 2025
AndyScherzinger
approved these changes
Aug 25, 2025
leftybournes
approved these changes
Aug 26, 2025
Member
|
Since #52752 has been backported, should this one be backported too? |
Contributor
Author
|
/backport to stable31 |
Contributor
Author
|
/backport to stable30 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since #52752 there are errors in the integration tests logs that says
"Dot files are not allowed"when a move is done for a file in the root folder.This is because dirname will return '.' for files at the root, which will cause an Exception that gets logged.
Instead use
\Sabre\Uri\splitlike other sabre plugins, to get an empty string for root directory.Checklist