fix(Dispatcher): Catch TypeErrors and turn them into bad request responses

[provokateurin]

Prevents error messages like this:

{"reqId":"ojXF2BwODOOk6tps9fW5","level":3,"time":"2025-08-20T11:32:03+00:00","remoteAddr":"::1","user":"admin","app":"no app in context","method":"DELETE","url":"/ocs/v2.php/cloud/users/admin/subadmins","message":"OCA\\Provisioning_API\\Controller\\UsersController::removeSubAdmin(): Argument #2 ($groupid) must be of type string, null given, called in /home/jld3103/src/github.com/nextcloud/server/lib/private/AppFramework/Http/Dispatcher.php on line 204 in file '/home/jld3103/src/github.com/nextcloud/server/apps/provisioning_api/lib/Controller/UsersController.php' line 1730","userAgent":"curl/8.15.0","version":"32.0.0.4","exception":{"Exception":"Exception","Message":"OCA\\Provisioning_API\\Controller\\UsersController::removeSubAdmin(): Argument #2 ($groupid) must be of type string, null given, called in /home/jld3103/src/github.com/nextcloud/server/lib/private/AppFramework/Http/Dispatcher.php on line 204 in file '/home/jld3103/src/github.com/nextcloud/server/apps/provisioning_api/lib/Controller/UsersController.php' line 1730","Code":0,"Trace":[{"file":"/home/jld3103/src/github.com/nextcloud/server/lib/private/AppFramework/App.php","line":153,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"/home/jld3103/src/github.com/nextcloud/server/lib/private/Route/Router.php","line":321,"function":"main","class":"OC\\AppFramework\\App","type":"::"},{"file":"/home/jld3103/src/github.com/nextcloud/server/ocs/v1.php","line":61,"function":"match","class":"OC\\Route\\Router","type":"->"},{"file":"/home/jld3103/src/github.com/nextcloud/server/ocs/v2.php","line":8,"args":["/home/jld3103/src/github.com/nextcloud/server/ocs/v1.php"],"function":"require_once"}],"File":"/home/jld3103/src/github.com/nextcloud/server/lib/private/AppFramework/Http/Dispatcher.php","Line":150,"Previous":{"Exception":"TypeError","Message":"OCA\\Provisioning_API\\Controller\\UsersController::removeSubAdmin(): Argument #2 ($groupid) must be of type string, null given, called in /home/jld3103/src/github.com/nextcloud/server/lib/private/AppFramework/Http/Dispatcher.php on line 204","Code":0,"Trace":[{"file":"/home/jld3103/src/github.com/nextcloud/server/lib/private/AppFramework/Http/Dispatcher.php","line":204,"function":"removeSubAdmin","class":"OCA\\Provisioning_API\\Controller\\UsersController","type":"->"},{"file":"/home/jld3103/src/github.com/nextcloud/server/lib/private/AppFramework/Http/Dispatcher.php","line":118,"function":"executeController","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"/home/jld3103/src/github.com/nextcloud/server/lib/private/AppFramework/App.php","line":153,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"/home/jld3103/src/github.com/nextcloud/server/lib/private/Route/Router.php","line":321,"function":"main","class":"OC\\AppFramework\\App","type":"::"},{"file":"/home/jld3103/src/github.com/nextcloud/server/ocs/v1.php","line":61,"function":"match","class":"OC\\Route\\Router","type":"->"},{"file":"/home/jld3103/src/github.com/nextcloud/server/ocs/v2.php","line":8,"args":["/home/jld3103/src/github.com/nextcloud/server/ocs/v1.php"],"function":"require_once"}],"File":"/home/jld3103/src/github.com/nextcloud/server/apps/provisioning_api/lib/Controller/UsersController.php","Line":1730},"message":"OCA\\Provisioning_API\\Controller\\UsersController::removeSubAdmin(): Argument #2 ($groupid) must be of type string, null given, called in /home/jld3103/src/github.com/nextcloud/server/lib/private/AppFramework/Http/Dispatcher.php on line 204 in file '/home/jld3103/src/github.com/nextcloud/server/apps/provisioning_api/lib/Controller/UsersController.php' line 1730","exception":{},"CustomMessage":"OCA\\Provisioning_API\\Controller\\UsersController::removeSubAdmin(): Argument #2 ($groupid) must be of type string, null given, called in /home/jld3103/src/github.com/nextcloud/server/lib/private/AppFramework/Http/Dispatcher.php on line 204 in file '/home/jld3103/src/github.com/nextcloud/server/apps/provisioning_api/lib/Controller/UsersController.php' line 1730"}}

The server is not doing anything wrong in this case and there is nothing the admin can do about it, because client is not sending a valid request to the endpoint.

[susnux]

Is really every type error a bad request? This seems to be very broad as there could also just be application logic issues in the controller?

[provokateurin]

Hm yes it could also be the fault of the code, but I think it is way more likely that it happens when the method is called and the request didn't provide valid parameters.

[susnux]

but I think it is way more likely that it happens when the method is called and the request didn't provide valid parameters.

how expensive would it be to use reflections and check this before?

[provokateurin]

Probably not expensive, since we already use reflection before to cast the values, but it will be a lot of messy code that might be incomplete. I would not go this route, so either we merge this PR or close it.

[nickvergessen]

This will be very painful for developers trying to figure out why something is not working during development 🙈

What I could see would be: when we have a TypeError, check if it's from the Controller::method call, if yes => debug, otherwise => error.
If that is too complicated, I vote for keeping everything error. It shouldn't happen regularly in prod anyway (when it does it also basically helps to notice BF attacks / scans going on)

[provokateurin]

It was actually quite easy to check with reflection whether the TypeError happened when calling the controller method or if it happened later on.

[nickvergessen]

🛑 Sounds okay to merge after branch off then? :P

[susnux]

@provokateurin Cypress seems to be related

[provokateurin]

Runner 8 with theming/admin-settings.cy.ts or something else?
If it's related, I really don't want to know how something depends on type errors 🙈

[susnux]

Hm I do not get it, it was broken with 8 retries and a rebase just fixed it...