enh(unified-search): Smarter load more #54312
Merged
Conversation
nfebe
requested review from
a team,
skjnldsv,
sorbaugh and
susnux
and removed request for
a team
skjnldsv
reviewed
Aug 7, 2025
icewind1991
approved these changes
Aug 7, 2025
skjnldsv
approved these changes
Aug 7, 2025
Member
|
/compile rebase |
skjnldsv
added
4. to release
This commit introduces a change to prevent showing the load more button, if the length of existing results is not equal to the requested limit (which implies it is less than because we never expect it to be more) Additionally, there is an enhancment to override provider filders passed to the find method. This would improve speed. Signed-off-by: nfebe <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
fix/smarter-loadmore-unified-search
branch
from
02c659c to
16f80a8
Compare
Contributor
Author
|
/backport to stable31 |
Contributor
Author
|
/backport to stable30 |
2 tasks
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces a change to prevent showing the load more button, if the length of existing results is not equal to the requested limit (which implies it is less than because we never expect it to be more)
Additionally, there is an enhancement to override provider filters passed to the find method. This would improve speed.