fix(encryption): Ignore shared files in encrypt-all command#54233
Merged
fix(encryption): Ignore shared files in encrypt-all command#54233
Conversation
Copying and renaming a share will not encrypt it anyway. It will get encrypted when the owner’s files get encrypted. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
added
3. to review
come-nc
requested review from
ArtificialOwl,
icewind1991,
provokateurin and
yemkareems
and removed request for
a team
yemkareems
approved these changes
Aug 4, 2025
icewind1991
approved these changes
Aug 5, 2025
Contributor
Author
|
✖ files_sharing/note-to-recipient.cy.ts 🤷 |
come-nc
added
4. to release
Member
|
backports ? |
Contributor
Author
|
/backport to stable31 |
Contributor
Author
|
/backport to stable30 |
9 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Copying and renaming a share will not encrypt it anyway. It will get encrypted when the owner’s files get encrypted.
This change should improve performance a bit on real world usecase, and may also avoid issues caused by uselessly renaming shares.
Checklist