Merged
Conversation
SystemKeeper
force-pushed
the
feat/noid/cache-user-keys
branch
2 times, most recently
from
7e15dee to
4870486
Compare
Contributor
Author
|
/backport to stable31 |
SystemKeeper
requested review from
ArtificialOwl,
CarlSchwan and
sorbaugh
and removed request for
a team
nickvergessen
approved these changes
Aug 3, 2025
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
As discussed, totally makes sense coming from the blackfire profile of the starting a call
nickvergessen
added
3. to review
come-nc
reviewed
Aug 5, 2025
SystemKeeper
force-pushed
the
feat/noid/cache-user-keys
branch
from
4870486 to
e4aeea5
Compare
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
SystemKeeper
force-pushed
the
feat/noid/cache-user-keys
branch
from
e4aeea5 to
520d8be
Compare
come-nc
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently all keys are always loaded from the file system, this is especially noticeable when push notifications are created. Since the keys are (usually) only generated once and do not change over time, we can also cache them and therefore prevent filesystem access.
Checklist