test: add env option to disable loading all installed apps during tests#54200
Merged
icewind1991 merged 1 commit intomasterfrom Aug 11, 2025
Merged
test: add env option to disable loading all installed apps during tests#54200icewind1991 merged 1 commit intomasterfrom
icewind1991 merged 1 commit intomasterfrom
Conversation
icewind1991
requested review from
CarlSchwan,
sorbaugh and
yemkareems
and removed request for
a team
susnux
approved these changes
Aug 1, 2025
Comment on lines
+26
to
+34
| $dontLoadApps = getenv('TEST_DONT_LOAD_APPS'); | ||
| if (!$dontLoadApps) { | ||
| // load all apps | ||
| $appManager = Server::get(IAppManager::class); | ||
| foreach (new \DirectoryIterator(__DIR__ . '/../apps/') as $file) { | ||
| if ($file->isDot()) { | ||
| continue; | ||
| } | ||
| $appManager->loadApp($file->getFilename()); |
Member
There was a problem hiding this comment.
Any merit to letting specific apps be specified?
Member
Author
There was a problem hiding this comment.
it is probably better to just let the user/automation manually enable the apps before starting phpunit for those cases.
icewind1991
force-pushed
the
test-disable-autoload-apps
branch
2 times, most recently
from
cb9cee2 to
e72a0e6
Compare
Altahrim
approved these changes
Aug 6, 2025
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
test-disable-autoload-apps
branch
from
e72a0e6 to
06be851
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatically loading all apps can lead to issues with local testing the dev has a lot of apps checked out which might not all be compatible with the current server version.
This adds an option to disable to autoloading by setting an env var