feat(AppMenu): add slight opactiy gradient to app icons#54178
Conversation
susnux
requested review from
nfebe,
skjnldsv and
sorbaugh
and removed request for
a team
susnux
added
enhancement
design
kra-mo
left a comment
kra-mo
left a comment
There was a problem hiding this comment.
Nice, definitely more noticeable with more than 2 icons :)
|
Although now looking at it, it seems like even 65% meets AA contrast levels with our default theme (even though before it looked like it didn't, color spaces are weird), maybe we could try that? That is what I originally got when playing around with the values. 
|
|
Oh and also… would this affect the right-side items like notifications and search? It would be nice if it did. |
szaimen
left a comment
szaimen
left a comment
There was a problem hiding this comment.
LGTM based on the screenshot. Do we know if this effects performance negatively?
skjnldsv
left a comment
skjnldsv
left a comment
There was a problem hiding this comment.
Beautiful!!
So glad mask is finally property supported globally
For 5-15 apps, I would be surprised if that would have a noticeable impact. But I'd be curious to be proven otherwise 🤔 |
susnux
force-pushed
the
feat/app-icon-opacity
branch
2 times, most recently
from
b19e1d0 to
012320b
Compare
susnux
requested review from
icewind1991 and
leftybournes
and removed request for
a team
I have slightly adjust the way it works, by defining a variable for it, this way we can do this in the library. Also fixed it for the high contrast theme. |
- resolves #54141 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
feat/app-icon-opacity
branch
from
012320b to
4e4c4d1
Compare
Allowing to have the new styles from #54178 and nextcloud-libraries/nextcloud-vue#7242 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Allowing to have the new styles from #54178 and nextcloud-libraries/nextcloud-vue#7242 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
@susnux @kra-mo so @AndyScherzinger and I just checked this out and we were wondering if we can go a bit lower than 75% opacity? Cause right now it is very nice, but indeed barely visible if you don’t know about it.
Yeah, I mentioned that I think 65 could work and might be nice. |
This comment was marked as resolved.
This comment was marked as resolved.
|
Guess I misunderstood, see #54418 :) |
5 participants
Summary
Now its a gradient from 100% opacity to 75% opacity.
If you think you see no difference, this is if I set from 100% to 40% 😉 :
Checklist