feat: send invitation emails through ICreateFromString#54160
Merged
Conversation
8d7b091 to
b1a106c
Compare
SebastianKrupinski
approved these changes
Jul 30, 2025
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
8bae652 to
d6d94c4
Compare
3 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ICalendarEventBuilderdo not trigger invitation emails #54062Summary
The
ICreateFromStringAPI does not send invitation emails currently. This should be considered a bug. However, we can't backport this fix as some of the consumers actually rely on this broken behavior, for example, Calendar appointments.Hence, I fixed the
createFromString()method and created a new onecreateFromStringMinimal()to keep the old behavior.Checklist