fix(BuildSocialSearchIndexBackgroundJob): ensure that special characters are handled correctly#54131
fix(BuildSocialSearchIndexBackgroundJob): ensure that special characters are handled correctly#54131
Conversation
|
/backport to stable31 |
|
/backport to stable30 |
f0ce856 to
aaee0a8
Compare
…ers are handled correctly Signed-off-by: Simon L. <[email protected]>
aaee0a8 to
840fba1
Compare
|
Hi, I find that, without additional context, a rather weird change. What problem did the customer run into? Also this pr changes only one write operation. If there's a problem, that non-utf-8-card-data must be sanitized, then it should happen in updateCard and createCard, no? |
ChristophWurst
left a comment
There was a problem hiding this comment.
I agree. This doesn't seem right.
The job is a one-time migration, no? What about non-UTF-8 data that was already processed by the job? It won't be fixed.
How did non-UTF-8 end up in the cards table if PUTing cards validates for UTF-8 too? Manual inserts?
|
Hello, I'm the customer who originally requested this fix. Best regards, |
Great, thank you for the feedback! Closing then :) |
Fix is done as suggested by customer