fix(files): Remove redundant setting#53885
Merged
Conversation
skjnldsv
requested review from
nfebe,
susnux and
szaimen
and removed request for
a team
Member
Author
|
/compile rebase |
This setting is already present in the main view, where it is much more visible, it is also the only one that is documented. Having it in both places is redundant and unnecessary clutter. Signed-off-by: kramo <git@kramo.page>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
remove-redundant-setting
branch
from
cf0c1e1 to
7f38fdf
Compare
susnux
approved these changes
Jul 9, 2025
Contributor
? |
Member
Author
Original PR is a fork, cypress doesn't work on forks. So I created the same here to ensure it passes before merging the original |
Member
Author
|
I mean, we could also just merge this one 🤷 |
Member
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #53663
Created this for testing only