Conversation
edward-ly
added
enhancement
3. to review
edward-ly
force-pushed
the
feat/context-chat-ocp
branch
from
4dc4697 to
1290be2
Compare
Member
|
Looks good! You can suppress psalm errors for the OCA\ContextChat classes by adding them to the psalm.xml suppress handler. |
marcelklehr
approved these changes
Jul 8, 2025
edward-ly
requested review from
icewind1991,
sorbaugh and
yemkareems
and removed request for
a team
This was referenced Jul 8, 2025
kyteinsky
approved these changes
Jul 9, 2025
kyteinsky
reviewed
Jul 9, 2025
edward-ly
force-pushed
the
feat/context-chat-ocp
branch
2 times, most recently
from
0291146 to
ccbf226
Compare
julien-nc
requested changes
Jul 11, 2025
Member
There was a problem hiding this comment.
It would be nice to have a isContextChatAvailable method in the content manager so providers could even avoid calling submitContent if it's not available.
There could be a new section in the docs (after "Submitting ContentItem data") about this new method.
Member
|
Ah, yes. Good point. OCA\ContextChat\Public\ContentManager would also have to implement this, then, which is a bit useless, but we can just return true there. |
julien-nc
requested changes
Jul 11, 2025
edward-ly
force-pushed
the
feat/context-chat-ocp
branch
from
6a256a8 to
87d4253
Compare
julien-nc
approved these changes
Jul 13, 2025
marcelklehr
force-pushed
the
feat/context-chat-ocp
branch
from
87d4253 to
70204ea
Compare
susnux
reviewed
Jul 14, 2025
marcelklehr
removed
the
pending documentation
susnux
reviewed
Jul 14, 2025
nickvergessen
previously requested changes
Jul 14, 2025
edward-ly
force-pushed
the
feat/context-chat-ocp
branch
2 times, most recently
from
c6efa0a to
fe7561d
Compare
Signed-off-by: Edward Ly <contact@edward.ly>
Signed-off-by: Edward Ly <contact@edward.ly>
…ContentManager Signed-off-by: Edward Ly <contact@edward.ly>
Signed-off-by: Edward Ly <contact@edward.ly>
Signed-off-by: Edward Ly <contact@edward.ly>
Signed-off-by: Edward Ly <contact@edward.ly>
edward-ly
force-pushed
the
feat/context-chat-ocp
branch
from
fe7561d to
aafcbcc
Compare
Member
|
Awesome! Great work @edward-ly |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist