fix: don't check if a customer share folder is configured for remote shares#53849
Closed
icewind1991 wants to merge 1 commit intomasterfrom
Closed
fix: don't check if a customer share folder is configured for remote shares#53849icewind1991 wants to merge 1 commit intomasterfrom
icewind1991 wants to merge 1 commit intomasterfrom
Conversation
8 tasks
provokateurin
requested changes
Jul 7, 2025
Member
provokateurin
left a comment
There was a problem hiding this comment.
commit message also has a typo
…shares Signed-off-by: Robin Appelman <robin@icewind.nl>
f5b78e5 to
5a4faba
Compare
provokateurin
approved these changes
Jul 11, 2025
This was referenced Aug 22, 2025
Merged
Merged
Merged
Merged
Merged
This was referenced Sep 25, 2025
Merged
Merged
st3iny
approved these changes
Oct 6, 2025
Member
|
Seems to be obsolete by now. server/lib/private/Share20/Manager.php Lines 707 to 713 in 774aad3 Please reopen if I'm wrong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No need to check for user preferences if
share_withisn't a user.Fixes #53830