docs(http): update return type for getBody#53679
Merged
Conversation
2781784 to
636af10
Compare
Contributor
Author
a0aef55 to
33feb34
Compare
❌ Unsupported file formatUpload processing failed due to unsupported file format. Please review the parser error message:
For more help, visit our troubleshooting guide. |
provokateurin
approved these changes
Jun 27, 2025
come-nc
reviewed
Jun 30, 2025
lib/private/Files/Storage/DAV.php
Outdated
| return $response->getBody(); | ||
| $content = $response->getBody(); | ||
|
|
||
| if (is_resource($content)) { |
Contributor
There was a problem hiding this comment.
I’m always scared by is_resource calls because of the long ongoing migration from resources to objects in PHP.
See https://php.watch/articles/resource-object
File handles are not planned to move to object yet but that may happen someday.
What about:
if (is_string($content) || $content === null) {
return false;
}
return $content;Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
33feb34 to
de54bdb
Compare
ChristophWurst
approved these changes
Jun 30, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
The code style update in pull request #53625 appears to trigger a Psalm warning about Response returning null, which makes it non-compliant with the interface.
Checklist