feat(lexicon): events onSet() and initialize()#53619
Closed
ArtificialOwl wants to merge 2 commits intomasterfrom
Closed
feat(lexicon): events onSet() and initialize()#53619ArtificialOwl wants to merge 2 commits intomasterfrom
ArtificialOwl wants to merge 2 commits intomasterfrom
Conversation
5 tasks
02593d5 to
106ba14
Compare
1b42dad to
d860cfd
Compare
2630b8f to
24c55f4
Compare
240bc41 to
ba11c71
Compare
Contributor
|
I’m a bit reluctant because this looks like a 4th event system 😒 But it’s not really events I suppose, it’s more validators and setters… unsure. |
Member
Author
still better than having a particular condition within the general/official setter |
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
ba11c71 to
fb1085d
Compare
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adding events when working on config keys
onSet()which is executed when a new value is set for this config key. Can be used to modify the new value before being stored into database, or to cancel the process if the new value is considered invalid (by returning false):addinitialize()which is executed when reading a config key that has no known value. Can be used to fill the value at first read, unless the closure returns falsenot in this PR anymore
``` (new ConfigLexiconEntry('email', ValueType::STRING, '', 'email'))->initialize( function (string &$value): void { $value = $this->secureRandom->generate(5, 'abcdefghijklmnopqrstuvwxyz0123456789'); } ), ```initialize()has been removed, will be prep in a separated PR and forgotten until it needs to be added in the future!