Merged
Conversation
come-nc
force-pushed
the
fix/cleanup-dicontainer
branch
3 times, most recently
from
f847eb6 to
8990f69
Compare
come-nc
force-pushed
the
fix/cleanup-dicontainer
branch
2 times, most recently
from
356e4ad to
9fbc182
Compare
Also removed deprecated tag from the class as this class will not be removed, only the interface IAppContainer and associated methods should be removed. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Some tests related to MiddlewareDispatcher are still failing. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
…teCookieMiddleware injection Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Cannot use an alias for this one, as it depends upon LoggerInterface so that creates an infinite loop. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Otherwise it gets resolved to \OC::$server. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
This caused a call to logger too soon in init phase Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
In this case we do not want the application DI container because we are requesting classes from other applications, so it’s better to ask the server container. We use \OCP\Server::get for this. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
…on container This make sure that all middlewares get a logger scoped to the application id, among other things. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
fix/cleanup-dicontainer
branch
from
d4fb88f to
2346a52
Compare
come-nc
requested review from
ArtificialOwl,
kesselb,
leftybournes,
provokateurin and
susnux
and removed request for
a team
susnux
approved these changes
Jul 8, 2025
provokateurin
approved these changes
Jul 8, 2025
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
Nice, maybe you could squash some of the commits to make bisecting easier in case any of the changes turn out to be problematic later on?
Contributor
Author
But CI won’t be green anymore 😨 |
Contributor
Author
|
I often prefer detailed commits, because you can treat them by batch if you want, while once squashed there is no going back. I’m gonna merge this version to move forward with this. I’ll try to do less commits next time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleanup DIContainer class.
Also removed the
@deprecatedtag from the class as this class will not be removed, only the interface IAppContainer and associated methods should be removed.Checklist