[files_versions] Fix sidebar version item style#53512
Conversation
julien-nc
requested review from
artonge and
nfebe
and removed request for
a team
|
/backport to stable31 |
|
/backport to stable30 |
|
/compile |
|
Why not give it enough space for « Current version » to be shown entirely? |
|
@tcitworld No reason. Anyway many translations of this string are longer and will be cut. |
skjnldsv
left a comment
skjnldsv
left a comment
There was a problem hiding this comment.
Code wise ok, I would indeed make the label flex-grow with a max-width :)
artonge
left a comment
artonge
left a comment
There was a problem hiding this comment.
@nextcloud/designers can you give us your opinion?
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Looks very nice @julien-nc! :)
Why not give it enough space for « Current version » to be shown entirely?
Agree with @tcitworld’s point – since the 100px width is an arbitrary value anyway, it might as well be a little bit wider so that our default texts are shown fully, at least in English. :)
…t get invisible if the author name is long Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
force-pushed
the
fix/noid/files-version-sidebar-item-style
branch
from
abe85ad to
422e3d9
Compare
|
/compile |
|
@jancborchardt Changed the min-width and updated the screenshot. |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
6 participants
Give the version label a min width so it does not get invisible when the author name is long.
Make sure the overflow ofboth version label and author name are ellispsised.
Before
After