fix: remove double cache write in ObjectStoreStorage::touch#53462
Merged
AndyScherzinger merged 1 commit intomasterfrom Jun 18, 2025
Merged
fix: remove double cache write in ObjectStoreStorage::touch#53462AndyScherzinger merged 1 commit intomasterfrom
AndyScherzinger merged 1 commit intomasterfrom
Conversation
come-nc
approved these changes
Jun 16, 2025
artonge
approved these changes
Jun 17, 2025
the file_put_contents already puts all of those values into the cache Signed-off-by: Robin Appelman <robin@icewind.nl>
e15fb56 to
2e1c316
Compare
Contributor
|
@icewind1991 This broke CI: https://github.com/nextcloud/server/actions/runs/15742834106/job/44373600796 This has been failing consistently on master since this PR was merged. |
Member
Author
|
Fix for test failures: #53650 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the file_put_contents already puts all of those values into the cache