fix: don't create an empty file before writing the contents in OC_Util::copyr#53461
Merged
icewind1991 merged 1 commit intomasterfrom Jun 25, 2025
Merged
fix: don't create an empty file before writing the contents in OC_Util::copyr#53461icewind1991 merged 1 commit intomasterfrom
icewind1991 merged 1 commit intomasterfrom
Conversation
icewind1991
requested review from
Altahrim,
skjnldsv and
sorbaugh
and removed request for
a team
icewind1991
force-pushed
the
copyr-no-empty-newfile
branch
from
49f6a11 to
f6ae853
Compare
…l::copyr Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
copyr-no-empty-newfile
branch
from
f6ae853 to
1d2b991
Compare
AndyScherzinger
approved these changes
Jun 24, 2025
Altahrim
approved these changes
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no need to write to the storage twice