fix: Do not enable applications which are not installed yet#53352
Merged
fix: Do not enable applications which are not installed yet#53352
Conversation
come-nc
requested review from
artonge,
icewind1991 and
sorbaugh
and removed request for
a team
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
fix/install-app-before-enable
branch
from
f50b954 to
bf340a5
Compare
This avoids spamming the appstore server and getting banned from CI runs Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
artonge
approved these changes
Jun 5, 2025
…t found Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
fix/install-app-before-enable
branch
from
fd971f1 to
c85f7ea
Compare
ChristophWurst
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It was previously possible for an application to be enabled but not installed, if this application is shipped and disabled by default, and enabled through the provisioning_api application.
This was the case of the testing application in integration tests, creating weird behaviors.
Checklist