feat(declarativeSettings): support encryption of sensitive values#53121
Merged
AndyScherzinger merged 2 commits intomasterfrom May 28, 2025
Merged
feat(declarativeSettings): support encryption of sensitive values#53121AndyScherzinger merged 2 commits intomasterfrom
AndyScherzinger merged 2 commits intomasterfrom
Conversation
andrey18106
requested review from
ArtificialOwl,
leftybournes,
skjnldsv,
susnux and
szaimen
and removed request for
a team
This was referenced May 26, 2025
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
LGTM, just some suggestions for improvements.
apps/settings/src/components/DeclarativeSettings/DeclarativeSection.vue
Outdated
Show resolved
Hide resolved
andrey18106
force-pushed
the
feat/sensitive-declarative-settings
branch
from
a2912d4 to
cd742aa
Compare
susnux
reviewed
May 27, 2025
susnux
reviewed
May 27, 2025
susnux
reviewed
May 27, 2025
susnux
approved these changes
May 27, 2025
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
LGTM except from the sprintf
andrey18106
force-pushed
the
feat/sensitive-declarative-settings
branch
from
cd742aa to
e570179
Compare
oleksandr-nc
approved these changes
May 28, 2025
Contributor
oleksandr-nc
left a comment
oleksandr-nc
left a comment
There was a problem hiding this comment.
overall it looks good
andrey18106
force-pushed
the
feat/sensitive-declarative-settings
branch
from
e570179 to
ca17680
Compare
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
andrey18106
force-pushed
the
feat/sensitive-declarative-settings
branch
from
7573fe6 to
7994332
Compare
Contributor
Author
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces new Declarative setting field attribute
sensitive: true/false, available forTextandPasswordfield types. Sensitive fields are encrypted on server side and the values are not exposed to the UI.Declarative forms with handler (https://github.com/nextcloud/server/blob/master/lib/public/Settings/IDeclarativeSettingsFormWithHandlers.php) must implement this in their
setValue,getValuemethods, as well as external storage type (using events to handle getValue/setValue actions).For ExApps AppAPI handles this automatically inside its event handlers.
TODO
Checklist