Skip to content

fix(files_trashbin): Expire trashbin items when space is needed#53112

Merged
provokateurin merged 1 commit intomasterfrom
leftybournes/fix/files_trashbin_retention
Jul 7, 2025
Merged

fix(files_trashbin): Expire trashbin items when space is needed#53112
provokateurin merged 1 commit intomasterfrom
leftybournes/fix/files_trashbin_retention

Conversation

@leftybournes
Copy link
Contributor

@leftybournes leftybournes commented May 26, 2025 •
edited by solracsf
Loading

Checklist

@leftybournes leftybournes requested a review from a team as a code owner May 26, 2025 01:55
@leftybournes leftybournes requested review from Altahrim, artonge and come-nc and removed request for a team May 26, 2025 01:55
@leftybournes leftybournes force-pushed the leftybournes/fix/files_trashbin_retention branch from dfff623 to 5207725 Compare May 26, 2025 02:37
@solracsf
Copy link
Member

solracsf commented May 26, 2025

Failing tests are related

@solracsf solracsf added this to the Nextcloud 32 milestone May 26, 2025
@leftybournes
Copy link
Contributor Author

leftybournes commented May 27, 2025 •
edited
Loading

Failing tests are related

Yup. The fix works fine on everything else but fails on object storage. Still looking for a solution.

@leftybournes leftybournes force-pushed the leftybournes/fix/files_trashbin_retention branch from 5207725 to 688ba2f Compare June 3, 2025 06:37
@codecov
Copy link

codecov bot commented Jun 3, 2025

❌ Unsupported file format

Upload processing failed due to unsupported file format. Please review the parser error message:

Error deserializing json

Caused by:
    expected value at line 1 column 1

For more help, visit our troubleshooting guide.

@leftybournes leftybournes force-pushed the leftybournes/fix/files_trashbin_retention branch from 688ba2f to 7f57fbc Compare June 3, 2025 08:04
@artonge
Copy link
Contributor

artonge commented Jun 10, 2025

/backport to stable31

@artonge
Copy link
Contributor

artonge commented Jun 10, 2025

/backport to stable30

icewind1991
icewind1991 approved these changes Jun 17, 2025
View reviewed changes
Copy link
Member

@icewind1991 icewind1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@leftybournes leftybournes force-pushed the leftybournes/fix/files_trashbin_retention branch 9 times, most recently from 950b175 to f54b9a3 Compare July 5, 2025 05:52
@leftybournes
fix(files_trashbin): Expire trashbin items when space is needed
1ccf491 
Signed-off-by: Kent Delante <kent.delante@proton.me>
@leftybournes leftybournes force-pushed the leftybournes/fix/files_trashbin_retention branch from f54b9a3 to 1ccf491 Compare July 5, 2025 06:12
@provokateurin provokateurin merged commit d3dd428 into master Jul 7, 2025
203 of 206 checks passed
@provokateurin provokateurin deleted the leftybournes/fix/files_trashbin_retention branch July 7, 2025 07:14
This was referenced Jul 7, 2025
Merged
Merged
@joshtrichards joshtrichards mentioned this pull request Aug 7, 2025
Closed
8 tasks
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@icewind1991 icewind1991 icewind1991 approved these changes

@provokateurin provokateurin provokateurin approved these changes

@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim is a code owner automatically assigned from nextcloud/server-backend

@artonge artonge Awaiting requested review from artonge artonge is a code owner automatically assigned from nextcloud/server-backend

@come-nc come-nc Awaiting requested review from come-nc come-nc is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to review Waiting for reviews feature: trashbin

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

[Bug]: files in the trash bin are not auto removed if storage space is needed

6 participants

@leftybournes @solracsf @artonge @icewind1991 @provokateurin @skjnldsv