perf(dav): Preload dav search with tags/favorites

[juliusknorr]

Save one query per file for aggregating tags/favorites on SEARCH requests by using the existing reload logic from propFinds.

This also introduces an event so it may be useful in other plugins in the future

https://blackfire.io/profiles/compare/1605ef6c-6a3d-4a77-aecd-69331df2b476/graph

[artonge]

I think tags should be fetched with the search query. At least we have equipQueryForSystemTags that should take care of it. Maybe we can either improve the request, or the logic to "equip" the query for system tags.

server/lib/private/Files/Cache/QuerySearchHelper.php

Lines 156 to 161 in 8bda2dc

	if (in_array('systemtag', $requestedFields)) {
	$this->equipQueryForSystemTags($query, $this->requireUser($searchQuery));
	}
	if (in_array('tagname', $requestedFields) || in_array('favorite', $requestedFields)) {
	$this->equipQueryForDavTags($query, $this->requireUser($searchQuery));
	}

What are the requested properties of the request?

[juliusknorr]

What are the requested properties of the request?

It is not about filtering for favorites but the search query asking for the <oc:favorite /> property on photos is triggering those

In the end this is hitting the regular PROPFIND plugins that extend the response through https://github.com/nextcloud/3rdparty/blob/ccc26ff9d787acddeb6a63c614317d19cb453c39/icewind/searchdav/src/DAV/SearchHandler.php#L88

[artonge]

Minor nitpicks, but looks good

[blizzz]

/backport to stable31

[blizzz]

/backport to stable30

[blizzz]

/backport to stable29

[blizzz]

• 30 backport in [stable30] perf(dav): Preload dav search with tags/favorites #53773
• 29 backport in [stable29] perf(dav): Preload dav search with tags/favorites #53774