Merged
Conversation
d96db5c to
9560e00
Compare
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
106be27 to
7c251e4
Compare
skjnldsv
approved these changes
May 28, 2025
susnux
approved these changes
Jun 2, 2025
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Given that:
I thereby declare it safe to delete the legacy autoloader and rely on sane modern autoloaders like the composer one instead.
Date of death 2025-05-19, after a long period with no brain activity.
I’m a bit sad to say this is not a noticable perf bump according to my testing, but it cannot hurt and opens the door to autoloader optimizing in the future.
Checklist