[stable30] fix(files_sharing): Show note if note exists on share#52850
Merged
[stable30] fix(files_sharing): Show note if note exists on share#52850
Conversation
nfebe
force-pushed
the
backport/52813/stable30
branch
from
4179226 to
7a7aa1d
Compare
nfebe
approved these changes
May 15, 2025
Contributor
|
/compile |
Contributor
|
/backport to stable29 |
artonge
approved these changes
May 15, 2025
Closed
AndyScherzinger
force-pushed
the
backport/52813/stable30
branch
from
18c54c0 to
8db4e54
Compare
When a share includes a note, ensure the note checkbox is checked and the note is displayed when reopening the share sidebar. Fixes: #52794. Signed-off-by: nfebe <fenn25.fn@gmail.com>
If a share note is present, the advanced settings should expand automatically, without the user needing to click. Signed-off-by: nfebe <fenn25.fn@gmail.com>
AndyScherzinger
force-pushed
the
backport/52813/stable30
branch
from
8db4e54 to
28ae3d3
Compare
Member
|
/compile / |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Author
|
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/52850/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick bd467605 28ae3d30 b7aa85dc
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/52850/stable29Error: Failed to check for changes with origin/stable29: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Contributor
|
/backport to stable29 |
Author
|
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/52850/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick bd467605 28ae3d30 b7aa85dc
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/52850/stable29Error: Failed to check for changes with origin/stable29: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #52813
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.