feat: move primary object store configuration to a single place#52816
Merged
icewind1991 merged 1 commit intomasterfrom May 28, 2025
Merged
feat: move primary object store configuration to a single place#52816icewind1991 merged 1 commit intomasterfrom
icewind1991 merged 1 commit intomasterfrom
Conversation
da651df to
56169fd
Compare
AndyScherzinger
approved these changes
May 14, 2025
come-nc
reviewed
May 14, 2025
56169fd to
2c98eea
Compare
come-nc
approved these changes
May 14, 2025
3ee53a3 to
3567dd1
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
3567dd1 to
7599162
Compare
Merged
Member
Author
|
/backport to stable31 |
Member
Author
|
/backport to stable30 |
|
The backport to # Switch to the target branch and update it
git checkout stable31
git pull origin stable31
# Create the new backport branch
git checkout -b backport/52816/stable31
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 7599162c
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/52816/stable31Error: Failed to push branch backport/52816/stable31: remote: {"auth_status":"auth_error","body":"Invalid username or token. Password authentication is not supported for Git operations."} Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #52786 to get smaller, easier to review PRs
Extracts and unifies the handling of primary object store configuration.
As with #52786, this also allows configuring multibucket object storages by settings the
multibucketarguments instead of having the configuration under the theobjectstore_multibucketkey. (it should have never be done like that tbh)