chore: move rmdirr implementation from OC legacy to OCP\Files#52812
chore: move rmdirr implementation from OC legacy to OCP\Files#52812
rmdirr implementation from OC legacy to OCP\Files#52812Conversation
2bea4fa to
c3501cd
Compare
rmdirr implementation from OC legacy to OCP\Files
c3501cd to
5e582cb
Compare
icewind1991
left a comment
There was a problem hiding this comment.
I'm not sure we want to add something to the public api that has been deprecated for 17 versions.
Since the use case for having such a function around seems sensible to me. I would rather clean it up a bit (give it a name that properly indicates that it's only for local files, ideally move it to a non-static place) and add it to the public api without deprecation.
@icewind1991 only the implementation is moved to OCP, the method is already in the public. But I agree we should cleanup this, but that would be more of a |
| * @return bool | ||
| * @since 5.0.0 | ||
| * @since 32.0.0 added the $deleteSelf parameter | ||
| * @deprecated 14.0.0 |
There was a problem hiding this comment.
So this one already exists in OCP @icewind1991.
I only moved the implementation of it.
There was a problem hiding this comment.
Ahh, missed that part 🙈
My point about having a ~7y old deprecated method that is apparently still useful enough to keep around still stands. So I would still like to see a cleaned up version of the method.
There was a problem hiding this comment.
Not sure we need it in public scope, its only used in private stuff.
Also accessing local files only makes sense in private stuff, public / apps should use app data or similar.
- move implementation to the OCP variant that called the legacy before - add the missing deprecation notice - add missing parameter to align both signatures - use OCP\Files where this method is still used Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
5e582cb to
072d4e8
Compare
come-nc
left a comment
There was a problem hiding this comment.
It’s better than before 🤷
Summary
Checklist