test(comments): Make Comments test result output properly readable#52626
Merged
nickvergessen merged 2 commits intomasterfrom May 5, 2025
Merged
test(comments): Make Comments test result output properly readable#52626nickvergessen merged 2 commits intomasterfrom
nickvergessen merged 2 commits intomasterfrom
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
requested review from
Altahrim,
ArtificialOwl and
artonge
and removed request for
a team
come-nc
approved these changes
May 5, 2025
provokateurin
approved these changes
May 5, 2025
Signed-off-by: Joas Schilling <coding@schilljs.com>
artonge
approved these changes
May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of the many "false is not true" errors on flaky tests we see at the moment, this should give clearer hints as to what is wrong. Also in quite many asserts the argument order was swapped, so it was not clear what was expected and what was actual.
Checklist