Fix theme logo position and shape#525
Merged
nickvergessen merged 4 commits intomasterfrom Jul 26, 2016
Merged
Conversation
|
@jospoortvliet, thanks for your PR! By analyzing the annotation information on this pull request, we identified @LukasReschke, @schiessle and @juliushaertl to be potential reviewers |
Member
make the logo look good on the login page
Member
|
Awesome. I'll hijack to fix the unit tests, @jospoortvliet :-) |
Member
|
Tests adjusted at 8457c61, now I'll leave that to the CSS gurus 😉 |
Member
|
I'll take over to fix the remaining css issues. |
Member
|
Should be done:
I guess this is now ready for review. |
Contributor
|
Backport would be nice. |
Member
|
Tested and works 👍 |
Member
|
@rullzer @Mar1u5 @nickvergessen @schiessle Review would be nice :) |
Member
|
looks good 👍 |
Member
cc @karlitschek |
Member
|
cool. please backport 👍 |
Member
|
I'll create a backport for this, just for Nextcloud 10 or also for Nextcloud 9 @karlitschek @MorrisJobke |
Member
|
i think both would be good |
This was referenced Jul 26, 2016
Member
|
Awesome work @juliushaertl! :) |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix from #344 (comment)
Working:
Still broken:
I can't figure out how to fix those. Leave it up to somebody with actual CSS fu.