fix(objectstorage): add retry attempts to S3 connection#52361
Merged
Conversation
miaulalala
requested review from
Altahrim,
icewind1991,
juliusknorr and
provokateurin
miaulalala
force-pushed
the
fix/51833/add-retries-to-s3-client
branch
from
627ea05 to
c456d35
Compare
Contributor
Author
|
/backport to stable31 |
Contributor
Author
|
/backport to stable30 |
solracsf
approved these changes
Apr 22, 2025
provokateurin
approved these changes
Apr 22, 2025
Signed-off-by: Anna Larch <anna@nextcloud.com>
miaulalala
force-pushed
the
fix/51833/add-retries-to-s3-client
branch
from
c456d35 to
49baa91
Compare
Altahrim
approved these changes
Apr 23, 2025
This was referenced Apr 23, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently, there are 3 retries attempted when uploading to the object storage, but only with the legacy option.
This PR adds a retry param to the S3Client with 5 retries in
standardmode as described in the documentation.TODO
Checklist