feat: add debug logging for adding/removing items from the user mounts cache#51921
Merged
feat: add debug logging for adding/removing items from the user mounts cache#51921
Conversation
icewind1991
requested review from
ArtificialOwl,
artonge and
provokateurin
and removed request for
a team
artonge
approved these changes
Apr 3, 2025
Contributor
artonge
left a comment
artonge
left a comment
There was a problem hiding this comment.
Will this give you the stack trace?
Member
Author
|
No, but I'm also not sure if a stacktrace adds much value here. The question is more what mounts are being added then what the code path is (that will be pretty much the same "setup fs" stack any time I assume). I will change it to add the mount provider the mount comes from as that might otherwise be non-obvious |
…s cache Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
usermountcache-logging
branch
from
b88add8 to
c3f06b3
Compare
Altahrim
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intended to try and figure out why there seems to be a higher than expected churn on the table