[stable31] fix(theming): enforce theme also for login#51753
Merged
[stable31] fix(theming): enforce theme also for login#51753
Conversation
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
skjnldsv
approved these changes
Mar 27, 2025
artonge
approved these changes
Mar 27, 2025
Comment on lines
+38
to
+40
| <body id="<?php p($_['bodyid']);?>" <?php foreach ($_['enabledThemes'] as $themeId) { | ||
| p("data-theme-$themeId "); | ||
| }?> data-themes="<?php p(join(',', $_['enabledThemes'])) ?>"> |
Member
There was a problem hiding this comment.
This breaks public/error pages it seems:
2025-04-03T20:40:27.000 m88 IP PHP Undefined array key "enabledThemes" at /var/www/cloud.nextcloud.com/nextcloud/core/templates/layout.guest.php#38 │
2025-04-03T20:40:28.000 m88 IP PHP foreach() argument must be of type array|object, null given at /var/www/cloud.nextcloud.com/nextcloud/core/templates/layout.guest.php#38 │
2025-04-03T20:40:28.000 m88 IP PHP Undefined array key "enabledThemes" at /var/www/cloud.nextcloud.com/nextcloud/core/templates/layout.guest.php#40 │
2025-04-03T20:40:28.000 m88 IP core Rendering themed error page failed. Falling back to un-themed error page. │
2025-04-03T20:40:28.000 m88 IP PHP Undefined array key "enabledThemes" at /var/www/cloud.nextcloud.com/nextcloud/core/templates/layout.guest.php#38 │
2025-04-03T20:40:29.000 m88 IP PHP foreach() argument must be of type array|object, null given at /var/www/cloud.nextcloud.com/nextcloud/core/templates/layout.guest.php#38 │
2025-04-03T20:40:29.000 m88 IP PHP Undefined array key "enabledThemes" at /var/www/cloud.nextcloud.com/nextcloud/core/templates/layout.guest.php#40 │
2025-04-03T20:40:29.000 m88 IP index join(): Argument #1 ($pieces) must be of type array, string given │
2025-04-03T20:40:29.000 m88 IP PHP Undefined array key "enabledThemes" at /var/www/cloud.nextcloud.com/nextcloud/core/templates/layout.guest.php#38 │
2025-04-03T20:40:29.000 m88 IP PHP foreach() argument must be of type array|object, null given at /var/www/cloud.nextcloud.com/nextcloud/core/templates/layout.guest.php#38 │
2025-04-03T20:40:30.000 m88 IP PHP Undefined array key "enabledThemes" at /var/www/cloud.nextcloud.com/nextcloud/core/templates/layout.guest.php#40 │
2025-04-03T20:40:30.000 m88 IP PHP TypeError: join(): Argument #1 ($pieces) must be of type array, string given at /var/www/cloud.nextcloud.com/nextcloud/core/templates/layout.guest.php#40
Member
There was a problem hiding this comment.
Easiest to demo is:
https://localhost/index.php/doesnotexist instead of an error message you will only see the background.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #50121
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.